Date: Fri, 3 Jan 2020 15:29:29 -0500 From: Ed Maste <emaste@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r356322 - head/share/mk Message-ID: <CAPyFy2DDTeXSojymsdxugAmaTTtpAfQ6qqnSOcv8=bb__nJqJg@mail.gmail.com> In-Reply-To: <CAGHfRMD=7%2BSibx54-0ViCzxPi2UBb0gQS5rRyxA=dJOBjAFvvQ@mail.gmail.com> References: <202001031811.003IBtqt019822@repo.freebsd.org> <CAGHfRMD=7%2BSibx54-0ViCzxPi2UBb0gQS5rRyxA=dJOBjAFvvQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 3 Jan 2020 at 14:23, Enji Cooper <yaneurabeya@gmail.com> wrote:
>
> Thank you for doing this <3. FWIW, MK_TESTS:= no should have also
> covered this, but no real harm nor foul in making it explicit.
Hmm, it looks like MK_TESTS_SUPPORT == no turns off MK_GOOGLETEST but
MK_TESTS does not. I'm happy enough if someone wants to clean this up
further, but IMO it's not worth putting in a lot of effort just yet;
in a few months GCC 4.2.1 and all of its build infrastructure will be
out of the tree and there may be many more opportunities to simplify
src.opts.mk logic. In particular all of the
${COMPILER_FEATURES:Mc++11} tests can disappear.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DDTeXSojymsdxugAmaTTtpAfQ6qqnSOcv8=bb__nJqJg>