Date: Wed, 22 Oct 2014 03:25:02 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Warner Losh <imp@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r273417 - head Message-ID: <86d29k28wh.fsf@nine.des.no> In-Reply-To: <201410212029.s9LKThT2074337@svn.freebsd.org> (Warner Losh's message of "Tue, 21 Oct 2014 20:29:43 %2B0000 (UTC)") References: <201410212029.s9LKThT2074337@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@FreeBSD.org> writes: > Author: imp > Date: Tue Oct 21 20:29:42 2014 > New Revision: 273417 > URL: https://svnweb.freebsd.org/changeset/base/273417 > > Log: > You aren't allowed to test WITH_xxx or WITHOUT_xxx here, so remove it. > Even if you were allowed to test for it, the test makes no sense as it > always results in adding -DWITH_ATF unless WITH_ATF was already > defined. But if MK_ATF !=3D no, then we know it was defined. This, in > turn, caused tools/build/options/makemake always think WITH_ATF is the > default, which removed control of that from sys.conf.mk. >=20=20=20 > To get the intent of the deleted comment, another mechanism is > required, assuming that the intent of that comment is desirable. This broke the paralell build. It prevents building lib/atf entirely in stage 4.3, so the programs in libexec/atf have nothing to link against unless lib/atf just happens to get built before libexec/atf. That almost never happens: lib and libexec are built in paralell, and lib/atf is one of the last items in lib whereas libexec/atf is one of the first items in libexec. (on a side note, libatf doesn't need to be in _prebuild_libs, since no other library depend on it) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86d29k28wh.fsf>