Date: Thu, 28 Jan 2021 18:29:19 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Alexander Richardson <arichardson@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 83ff5d5d98cb - main - Un-XFAIL two tests with Clang > 10 Message-ID: <A2987B7A-DF98-428F-9689-E2BB6D5A290A@freebsd.org> In-Reply-To: <CA%2BZ_v8o1P=3R196FwzDff2SM%2BJ9Hrcp_QKzkVyayvhVASwWi9A@mail.gmail.com> References: <202101281739.10SHdh37056796@gitrepo.freebsd.org> <6B60F7D5-AD3E-459E-801A-65234A689A01@freebsd.org> <CA%2BZ_v8o1P=3R196FwzDff2SM%2BJ9Hrcp_QKzkVyayvhVASwWi9A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Jan 2021, at 17:46, Alexander Richardson <arichardson@freebsd.org> wrote: > On Thu, 28 Jan 2021 at 17:42, Jessica Clarke <jrtc27@freebsd.org> wrote: >> >> Is the commit message or the diff wrong? Both use strict inequalities. >> >> Jess > > Sorry the commit message should be >= 10. Thanks. I see now the first XFAIL message was updated to say 7-9 (which answers my question), but the second one I was looking at was not. Could you please correct that? Jess >> >> On 28 Jan 2021, at 17:39, Alex Richardson <arichardson@FreeBSD.org> wrote: >>> >>> The branch main has been updated by arichardson: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=83ff5d5d98cbcf9b66dccd70022358aec8918a14 >>> >>> commit 83ff5d5d98cbcf9b66dccd70022358aec8918a14 >>> Author: Alex Richardson <arichardson@FreeBSD.org> >>> AuthorDate: 2021-01-28 17:17:49 +0000 >>> Commit: Alex Richardson <arichardson@FreeBSD.org> >>> CommitDate: 2021-01-28 17:24:24 +0000 >>> >>> Un-XFAIL two tests with Clang > 10 >>> >>> SVN r343917 fixed this for in-tree clang, but when building with a newer >>> out-of-tree clang the test was still marked as XFAIL. >>> >>> Reviewed By: dim >>> Differential Revision: https://reviews.freebsd.org/D28390 >>> --- >>> contrib/netbsd-tests/lib/libm/t_cbrt.c | 4 ++-- >>> lib/msun/tests/trig_test.c | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/contrib/netbsd-tests/lib/libm/t_cbrt.c b/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> index d2cdd47a5beb..08e9faeb145c 100644 >>> --- a/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> +++ b/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> @@ -269,8 +269,8 @@ ATF_TC_BODY(cbrtl_powl, tc) >>> size_t i; >>> >>> #if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7 && \ >>> - __FreeBSD_cc_version < 1300002 >>> - atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); >>> + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 >>> + atf_tc_expect_fail("test fails with clang 7-9 - bug 234040"); >>> #endif >>> >>> for (i = 0; i < __arraycount(x); i++) { >>> diff --git a/lib/msun/tests/trig_test.c b/lib/msun/tests/trig_test.c >>> index 483a5e187d50..ba1975721d3f 100644 >>> --- a/lib/msun/tests/trig_test.c >>> +++ b/lib/msun/tests/trig_test.c >>> @@ -161,7 +161,7 @@ ATF_TC_BODY(reduction, tc) >>> unsigned i; >>> >>> #if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7 && \ >>> - __FreeBSD_cc_version < 1300002 >>> + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 >>> atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); >>> #endif >>> >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A2987B7A-DF98-428F-9689-E2BB6D5A290A>