Date: Sun, 18 Feb 2007 05:28:33 -0800 From: Brian Somers <brian@Awfulhak.org> To: Max Laier <max@love2party.net> Cc: cvs-src@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/digi digi.c src/sys/kern kern_linker.c subr_firmware.c src/sys/sys linker.h Message-ID: <20070218052833.1923d347@dev.lan.Awfulhak.org> In-Reply-To: <200702152102.06506.max@love2party.net> References: <200702151949.l1FJnSnp061671@repoman.freebsd.org> <200702152102.06506.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 15 Feb 2007 21:01:57 +0100 Max Laier <max@love2party.net> wrote: > On Thursday 15 February 2007 20:49, Luigi Rizzo wrote: > > luigi 2007-02-15 19:49:27 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/dev/digi digi.c > > sys/kern kern_linker.c subr_firmware.c > > sys/sys linker.h > > Log: > > MFC kern_linker.c 1.133 and related changes: > > > > - push Giant into linker_reference_module(); > > - introduce linker_release_module(), which also takes care of > > proper locking. > > > > The latter also fixes a missing mtx_loc/unlock in subr_firmware.c . > > > > Apparently, digi.c is the only external client of > > linker_reference_module() which is a bit suspicious - perhaps dev/digi/ > > could make with a bit of review from someone knowledgeable to check how > > the function is used, and whether it could be replaced by something > > else. > > I have a version of digi(4) in perforce that uses firmware(9). I couldn't > find testers, but with a bit of review this should be committable > nonetheless. > > http://perforce.freebsd.org/depotTreeBrowser.cgi?FSPC=//depot/user/mlaier/firmware/sys/dev/digi/&HIDEDEL=NO > > > Revision Changes Path > > 1.58.2.3 +3 -3 src/sys/dev/digi/digi.c > > 1.117.2.2 +31 -1 src/sys/kern/kern_linker.c > > 1.1.2.4 +1 -3 src/sys/kern/subr_firmware.c > > 1.39.2.2 +8 -0 src/sys/sys/linker.h > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News I could probably do some testing here - I have some digi cards (although only one PCI one AFAIR!!). I originally added linker_reference_module() because I wanted to be able to dynamically load a module from another module, or take a reference to it if it's already there. This was a good way to load/unload the different firmware types after figuring out what the card type is. If firmware(9) avoids this necessity, I'm all for doing away with linker_reference_module(). -- Brian Somers <brian@Awfulhak.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070218052833.1923d347>