Date: Fri, 13 Feb 2015 17:56:34 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: phabric-admin@FreeBSD.org Cc: svn-src-head@freebsd.org, Randall Stewart <rrs@FreeBSD.org>, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org Subject: Phabricator + 'Reviewed by' [was Re: svn commit: r278472 - in head/sys: netinet netinet6] Message-ID: <54DE8F32.2090500@FreeBSD.org> In-Reply-To: <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> References: <201502091928.t19JSC5P066293@svn.freebsd.org> <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2/9/2015 3:45 PM, Bjoern A. Zeeb wrote: >> Commented upon by hiren and sbruno >> See Phabricator D1777 for more details. >> >> Commented upon by hiren and sbruno >> Reviewed by: adrian, jhb and bz > I have not reviewed this; as a matter of fact you are aware that I still wanted to do that. > Something about Phabricator is not jiving with our commit terminology. This has happened before as well with other commits. I'm sure everyone is good-intentioned as well. There's not 1 person on D1777 who has 'accepted' it. That is what warrants a 'Reviewed by' to me. It's clear to me, but seems unclear to others. I really think the reviewer list needs to be split up. Rather than using icons, use separate lists. Reviewers requested: accepted: commented: changes requested:. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU3o83AAoJEDXXcbtuRpfPbO4IAK82RIVhFWKAH8z5hdPgzTlL X//0xTRpXCrTrUH0v/ZYsEyrZ7AtquybHaZ+QPYoL/vFwnst24FvXkOe2DReDMD0 ej0h7bmYHzhPP9i5sKNLr/xRZ/ngj09pgDL0UHhJJ5Ax60nDvtpIvSQdkAl6gGad 2SdXhYVy596406WfjWA95gf1a2Mc6npoQ+lCO8BobOKnwsu140xIYIGP4bAtIpKb kgW9YKo491n4UzWg7FgqpH1im13DNTdzl9CgJa+UxkfW1CF8sO0ER/sjmH3B3KCn zSsaydw85xOdFhygRuNcHfW3NWhCaiYVH27i6KZ2Dx9KuFCMxrJmelw/Z8x1vV0= =7Ofk -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54DE8F32.2090500>