Date: Sat, 20 Apr 2019 12:51:06 +0000 (UTC) From: Alan Somers <asomers@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r346441 - in head/sys/modules: em fusefs iavf Message-ID: <201904201251.x3KCp6it044898@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: asomers Date: Sat Apr 20 12:51:05 2019 New Revision: 346441 URL: https://svnweb.freebsd.org/changeset/base/346441 Log: Use symlinks for kernel modules rather than hardlinks When aliasing a kernel module to a different name (ie if_igb for if_em), it's better to use symlinks than hard links. kldxref will omit entries for the links, ensuring that the loaded module has the correct name. Reviewed by: imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D19979 Modified: head/sys/modules/em/Makefile head/sys/modules/fusefs/Makefile head/sys/modules/iavf/Makefile Modified: head/sys/modules/em/Makefile ============================================================================== --- head/sys/modules/em/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/em/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -22,6 +22,6 @@ CFLAGS += -I${SRCTOP}/sys/dev/e1000 # DEVICE_POLLING for a non-interrupt-driven method #CFLAGS += -DDEVICE_POLLING -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/if_igb.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/if_igb.ko .include <bsd.kmod.mk> Modified: head/sys/modules/fusefs/Makefile ============================================================================== --- head/sys/modules/fusefs/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/fusefs/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -8,6 +8,6 @@ SRCS= vnode_if.h \ fuse_vfsops.c fuse_vnops.c fuse_internal.c fuse_main.c # Symlink for backwards compatibility with systems installed at 12.0 or older -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/fuse.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/fuse.ko .include <bsd.kmod.mk> Modified: head/sys/modules/iavf/Makefile ============================================================================== --- head/sys/modules/iavf/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/iavf/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -15,6 +15,6 @@ SRCS += i40e_common.c i40e_nvm.c i40e_adminq.c # Enable asserts and other debugging facilities # CFLAGS += -DINVARIANTS -DINVARIANTS_SUPPORT -DWITNESS -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/if_ixlv.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/if_ixlv.ko .include <bsd.kmod.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904201251.x3KCp6it044898>