Date: Wed, 16 Mar 2016 21:29:50 -0700 From: Xin LI <delphij@gmail.com> To: Alan Somers <asomers@freebsd.org>, Sean Fagan <sef@ixsystems.com> Cc: Xin LI <delphij@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools Message-ID: <CAGMYy3tA7xPpo4UJT7jaKJgR52CcuB-9%2BRCWvw0bLMukSzCo%2BA@mail.gmail.com> In-Reply-To: <CAOtMX2j8v5hr_R37AOrrTWx=8_=qHyk4MbdhfPr57%2BvRMzW9dw@mail.gmail.com> References: <201509040014.t840ELno034811@repo.freebsd.org> <CAOtMX2j8v5hr_R37AOrrTWx=8_=qHyk4MbdhfPr57%2BvRMzW9dw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
+sef who created the patch... On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers <asomers@freebsd.org> wrote: > > > On Thu, Sep 3, 2015 at 6:14 PM, Xin LI <delphij@freebsd.org> wrote: >> >> Author: delphij >> Date: Fri Sep 4 00:14:20 2015 >> New Revision: 287445 >> URL: https://svnweb.freebsd.org/changeset/base/287445 >> >> Log: >> Expose an interface to determine if an ACE is inherited. >> >> Submitted by: sef >> Reviewed by: trasz >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D3540 >> >> Modified: >> head/bin/setfacl/setfacl.1 >> head/lib/libc/posix1e/acl_add_flag_np.3 >> head/lib/libc/posix1e/acl_support_nfs4.c >> head/share/man/man9/acl.9 >> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c >> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h >> head/sys/kern/subr_acl_nfs4.c >> head/sys/sys/acl.h >> head/tools/regression/acltools/tools-crossfs.test >> head/tools/regression/acltools/tools-nfs4-psarc.test >> head/tools/regression/acltools/tools-nfs4-trivial.test >> head/tools/regression/acltools/tools-nfs4.test > > > ... > >> >> Modified: head/sys/sys/acl.h >> >> ============================================================================== >> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015 (r287444) >> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015 (r287445) >> @@ -249,11 +249,12 @@ typedef void *acl_t; >> #define ACL_ENTRY_INHERIT_ONLY 0x0008 >> #define ACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 >> #define ACL_ENTRY_FAILED_ACCESS 0x0020 >> +#define ACL_ENTRY_INHERITED 0x0080 >> >> #define ACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | >> \ >> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ >> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ >> - ACL_ENTRY_FAILED_ACCESS) >> + ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) >> >> /* >> * Undefined value in ae_id field. ae_id should be set to this value > > > Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead > of 0x0040 ? > -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGMYy3tA7xPpo4UJT7jaKJgR52CcuB-9%2BRCWvw0bLMukSzCo%2BA>