Date: Sun, 28 Dec 2008 07:53:01 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Alfred Perlstein <alfred@freebsd.org> Cc: Scott Long <scottl@samsco.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "mav@freebsd.org" <mav@freebsd.org>, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: svn commit: r186182 - head/sys/dev/ata Message-ID: <32523.1230450781@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 27 Dec 2008 21:35:30 PST." <20081228053530.GF18389@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20081228053530.GF18389@elvis.mu.org>, Alfred Perlstein writes: >* Scott Long <scottl@samsco.org> [081226 18:34] wrote: >> I prefer to do nothing. It's not unsafe or erroneous to access cfg >> registers. But if some kind of message does get added, I insist that >> it drop all pretenses and say, "you're too poor to run freebsd, come >> back when you can afford better hardware.". :) > >Well that could be the result of a driver that has a "bug" that >makes it access cfg space when it does not need to, as what seems >to have just been fixed. How about adding a counter and a rate warning under INVARIANTS ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32523.1230450781>