Date: Thu, 01 Aug 2013 20:27:31 +0400 From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, Hiroki Sato <hrs@FreeBSD.org> Subject: Re: svn commit: r253841 - head/sys/netinet6 Message-ID: <51FA8C73.4070808@FreeBSD.org> In-Reply-To: <97527D06-7783-4441-BA50-702DEE0B9076@FreeBSD.org> References: <201307311624.r6VGOob5022079@svn.freebsd.org> <20130801142324.GG20104@FreeBSD.org> <97527D06-7783-4441-BA50-702DEE0B9076@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01.08.2013 20:18, Rui Paulo wrote: > On 1 Aug 2013, at 07:23, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > >> On Wed, Jul 31, 2013 at 04:24:50PM +0000, Hiroki Sato wrote: >> H> Author: hrs >> H> Date: Wed Jul 31 16:24:49 2013 >> H> New Revision: 253841 >> H> URL: http://svnweb.freebsd.org/changeset/base/253841 >> H> >> H> Log: >> H> Allocate in6_ifextra (ifp->if_afdata[AF_INET6]) only for IPv6-capable >> H> interfaces. This eliminates unnecessary IPv6 processing for non-IPv6 >> H> interfaces. >> H> >> H> MFC after: 3 days >> H> >> H> Modified: >> H> head/sys/netinet6/in6.c >> H> head/sys/netinet6/in6_ifattach.c >> H> head/sys/netinet6/nd6.c >> H> >> H> Modified: head/sys/netinet6/in6.c >> H> ============================================================================== >> H> --- head/sys/netinet6/in6.c Wed Jul 31 15:55:01 2013 (r253840) >> H> +++ head/sys/netinet6/in6.c Wed Jul 31 16:24:49 2013 (r253841) >> H> @@ -2746,6 +2746,13 @@ in6_domifattach(struct ifnet *ifp) >> H> { >> H> struct in6_ifextra *ext; >> H> >> H> + /* There are not IPv6-capable interfaces. */ >> H> + switch (ifp->if_type) { >> H> + case IFT_PFLOG: >> H> + case IFT_PFSYNC: >> H> + case IFT_USB: >> H> + return (NULL); >> H> + } >> >> All three should just disappear as interfaces :) > > What? Why? Because thay aren't really interfaces. All they need is BPF. There is a cleaner approach described here: http://lists.freebsd.org/pipermail/freebsd-net/2012-December/034031.html > > -- > Rui Paulo > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51FA8C73.4070808>