Date: Thu, 27 Oct 2005 08:33:53 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Yar Tikhiy <yar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd Message-ID: <20051027063353.GA63896@garage.freebsd.pl> In-Reply-To: <200510231406.j9NE6r8L008373@repoman.freebsd.org> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7JfCtLOvnd9MIVvH
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote:
+> yar 2005-10-23 14:06:53 UTC
+>=20
+> FreeBSD src repository
+>=20
+> Modified files:
+> etc/rc.d ike named ppp-user sshd=20
+> Log:
+> Don't be lazy, set the "command" variable even if
+> /etc/defaults/rc.conf will provide foo_program, too.
+> By specifying "command" we explicitly say that we're
+> going to rely on rc.subr(8) default methods, and
+> rc.subr(8) will take advantage of this soon.
+> =20
+> The majority of our rc.d scripts already set "command"
+> if appropriate, so fix just the non-compliant handful.
[...]
+> name=3D"named"
+> rcvar=3D`set_rcvar`
+> +command=3D"/usr/sbin/${name}"
[...]
+> name=3D"ppp"
+> rcvar=3D`set_rcvar`
+> +command=3D"/usr/sbin/ppp"
[...]
+> name=3D"sshd"
+> rcvar=3D`set_rcvar`
+> +command=3D"/usr/sbin/${name}"
Any reason you didn't used ${name} in ppp case?
--=20
Pawel Jakub Dawidek http://www.wheel.pl
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
--7JfCtLOvnd9MIVvH
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD4DBQFDYHTRForvXbEpPzQRAiklAJiQ+ROz3lYY7hj5N4aliON6eqH0AKD4G6jF
5QzB6sUlkGYwRgkS0DZ2Fw==
=zflN
-----END PGP SIGNATURE-----
--7JfCtLOvnd9MIVvH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051027063353.GA63896>