Date: Thu, 22 Mar 2007 10:40:33 +0100 From: "[LoN]Kamikaze" <LoN_Kamikaze@gmx.de> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Gabor Kovesdan <gabor@FreeBSD.org>, cvs-ports@FreeBSD.org, erwin@freebsd.org, Christian Lackas <delta@lackas.net> Subject: Re: cvs commit: ports/security/vpnc Makefile ports/security/vpnc/files vpnc.in vpnc.sh Message-ID: <46024F11.1040600@gmx.de> In-Reply-To: <45E3701E.9000900@FreeBSD.org> References: <200702261857.l1QIvVMT051664@repoman.freebsd.org> <45E3701E.9000900@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Doug Barton wrote: > 5. In vpnc_start() you could simplify the code by doing: > > if ! $command $current $vpnc_flags; then > status=$? > echo "Running 'vpnc $current $vpnc_flags' failed." > return $status > fi That was a really bad idea, because it causes status to always be 0. Which is probably not the right thing to return in case of an error.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46024F11.1040600>