Date: Wed, 25 Feb 2009 21:52:53 +0100 From: Ed Schouten <ed@80386.nl> To: Robert Noland <rnoland@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189052 - head/sys/dev/drm Message-ID: <20090225205253.GT19161@hoeg.nl> In-Reply-To: <1235593885.1273.80.camel@widget.2hip.net> References: <200902251854.n1PIsZZP005285@svn.freebsd.org> <20090225194228.GS19161@hoeg.nl> <1235593885.1273.80.camel@widget.2hip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--rE45P3aZNSuYx5ND
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
* Robert Noland <rnoland@FreeBSD.org> wrote:
> On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
> > Hi Robert,
> >=20
> > * Robert Noland <rnoland@FreeBSD.org> wrote:
> > > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
> > > + {0x8086, 0x2772}, /* Intel i945G */ \
> > > + {0x8086, 0x27A2}, /* Intel i945GM */ \
> > > + {0x8086, 0x27AE}, /* Intel i945GME */ \
> > > + {0, 0}
> > > +};
> >=20
> > Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
> > definitions here?
>=20
> Where are those located? The rest of drm just uses the hex id's, if
> there is a better way, I'm up for it.
Oh wait, I always thought they were part of some kind of central list,
like usbdevs, but it turns out device drivers just #define them
themselves. Never mind.
--=20
Ed Schouten <ed@80386.nl>
WWW: http://80386.nl/
--rE45P3aZNSuYx5ND
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkmlr6UACgkQ52SDGA2eCwWGewCffM2om+1yKrZLz00nboWoEosK
u0oAnjPFqRRqsmweKvf7HfHOxaOaQ9E9
=6N9f
-----END PGP SIGNATURE-----
--rE45P3aZNSuYx5ND--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090225205253.GT19161>