Date: Fri, 29 May 2009 10:41:38 -0400 From: John Baldwin <jhb@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: Rui Paulo <rpaulo@freebsd.org>, Robert Noland <rnoland@freebsd.org>, Ariff Abdullah <ariff@freebsd.org>, freebsd-current@freebsd.org, Sam Leffler <sam@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: fixing kobj signatures Message-ID: <200905291041.39168.jhb@freebsd.org> In-Reply-To: <4A1FEE04.1060202@freebsd.org> References: <4A1FEE04.1060202@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 29 May 2009 10:15:32 am Andriy Gapon wrote: > > I think I have completed fixing signatures of kobj method implementations in the > whole head tree. > The current diff here: > http://people.freebsd.org/~avg/ > > It is quite arbitrarily split into the following files: > kobj-agp.diff > kobj-arm.diff > kobj-linker.diff > kobj-other.diff > kobj-sound.diff I haven't looked at kobj-sound, but the rest of these look fine to me. I would drop the 'XXX' comments from return values in miibus_write_reg() routines as 'return (0)' in every case seems to be consistent with other NIC drivers. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905291041.39168.jhb>