Date: Thu, 18 Oct 2007 10:45:06 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Peter Jeremy <peterjeremy@optushome.com.au> Cc: josh.carroll@gmail.com, Andrey Chernov <ache@nagual.pp.ru>, ??? Bill Hacker <askbill@conducive.net>, freebsd-current@freebsd.org, Kostik Belousov <kostikbel@gmail.com>, Artem Kuchin <matrix@itlegion.ru> Subject: Re: Broken su in current - trying to fix myself, help needed! Message-ID: <20071018174506.GB420@dragon.NUXI.org> In-Reply-To: <20071017193615.GO9006@server.vk2pj.dyndns.org> References: <00bd01c810ec$10371230$0c00a8c0@Artem> <8cb6106e0710171143m3dff7546o457192ede76e6598@mail.gmail.com> <012c01c810f3$aafeecf0$0c00a8c0@Artem> <20071017193615.GO9006@server.vk2pj.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 18, 2007 at 05:36:15AM +1000, Peter Jeremy wrote: > This bug (or another one with identical symptoms) affects the 'su' > commands within the ports build system if you are using tcsh or zsh or bash It has been suggested that reverting rev 1.79 of su.c may address the issue. ---------------------------- revision 1.79 date: 2006/01/03 09:17:04; author: brian; state: Exp; lines: +14 -1 Fix the other su bug reintroduced two commits ago, namely $ su % kill -STOP $$ where su is executing (t)csh. csh's job handling is a little more special than that of (a)sh, bash and even zsh and blows up a little more spectacularly. This modification restores the original mucking about with the tty pgrp, but is careful to only do it when su (or su's child) is the foreground process ---------------------------- -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? Let's not play "Jeopardy-style quoting"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071018174506.GB420>