Date: Fri, 18 Jan 2019 15:57:54 +0700 From: Eugene Grosbein <eugen@freebsd.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim Message-ID: <ac84c6ee-98e3-3d1d-59ac-dbf0da893e9e@freebsd.org> In-Reply-To: <CAG6CVpXzqj2Qg0jRwFB7t6xnbLQZ_uLcPZ=rSfAJYE-t4vSHYw@mail.gmail.com> References: <201901171808.x0HI80jC068564@repo.freebsd.org> <CAG6CVpVBsFDgksLEWG_U%2B4k6tH3SnaZkNFgd77D8NfLDf21Pdg@mail.gmail.com> <2d239dc0-915c-2d2b-0936-a40af5e9ead9@freebsd.org> <CAG6CVpXzqj2Qg0jRwFB7t6xnbLQZ_uLcPZ=rSfAJYE-t4vSHYw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
18.01.2019 4:45, Conrad Meyer wrote: >>> Please back it out; stop attributing code review to "hackers@," which >>> can not (it's a list, not individuals) and did not review this >>> changeset; and put it on phabricator for actual review. >> >> There is already https://reviews.freebsd.org/D18380 by imp >> and there were over 6 weeks since it had an update. >> Newly committed code has most of its changes. > > Your response does not address *any* of the above concerns. It's just > unrelated. > > The review you linked to isn't one you submitted for this change; This is a review still. > it's Warner's, and that one stalled because you were such a jerk to him This is not true. > last time that he needed time off from you. Please do not speak for him. > If you want to socialize, revive, or expedite someone else's review, > maybe add a new comment to the review, I did. > or post a discussion hackers@, I did. > or something like that. You still can't attribute code review to > hackers@, especially as no such review happened. It happened a week before I make first commit, in a way. I cannot make people do a review if they do not want to review. And we still had no utility to do the job.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac84c6ee-98e3-3d1d-59ac-dbf0da893e9e>