Date: Sat, 20 Jun 2026 18:07:08 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Mark Johnston <markj@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 949804c81909 - main - nvme: Use newbus to ask if a device is storage Message-ID: <86qzm1tcur.fsf@ltc.des.dev> In-Reply-To: <ajahrZ7Ux85D6K_M@framework> (Mark Johnston's message of "Sat, 20 Jun 2026 10:20:29 -0400") References: <6a32b7af.3e162.34185707@gitrepo.freebsd.org> <ajahrZ7Ux85D6K_M@framework>
index | next in thread | previous in thread | raw e-mail
Mark Johnston <markj@freebsd.org> writes:
> Warner Losh <imp@freebsd.org> writes:
> > + static bool
> > + default_is_storage_device(device_t dev)
> > + {
> > + return (true);
> > + }
> After this commit I see a warning during buildkernel of a GENERIC
> kernel:
>
> nvme_if.c:21:1: warning: unused function 'default_is_storage_device' [-Wunused-function]
Easily fixed by changing `static bool` to `static inline bool`.
DES
--
Dag-Erling Smørgrav - des@FreeBSD.org
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86qzm1tcur.fsf>