Date: Tue, 06 Mar 2001 18:23:29 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Warner Losh <imp@harmony.village.org> Cc: igorr@crosswinds.net, freebsd-current@FreeBSD.org, phk@FreeBSD.org Subject: Re: Correct size of kinfo_proc Message-ID: <3AA50F01.6560C34A@FreeBSD.org> References: <20010228161009.B14235@linux.rainbow> <3A9CF680.563D9F2B@FreeBSD.org> <200103010440.f214e1d45348@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote: > In message <20010228161009.B14235@linux.rainbow> Igor Robul writes: > : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote: > : > Hi Poul, > : > > : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to > : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE from 644 to 648. > : > Please correct. > : Why don't use sizeof() insead of hardcoding numbers? > > Because KINFO_PROC_SIZE is part of the ABI. Changes to its size are > always wrong, in that they break the ABI. The checks are there to > tell us when the ABI has been broken. Well, we are now well informed about this, could we just fix sys/sys/user.h to match relity (credit goes to phk for broking it and ignoring my posts completely)? max@notebook$ dmesg | grep WARNING WARNING: size of kinfo_proc (648) should be 644!!! max@notebook$ uname -a FreeBSD notebook 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Tue Mar 6 15:34:23 EET 2001 root@notebook:/usr/src/sys/compile/NOTEBOOK i386 -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AA50F01.6560C34A>