Date: Wed, 25 Feb 2009 15:05:16 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: ed@80386.nl Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, rnoland@FreeBSD.org Subject: Re: svn commit: r189052 - head/sys/dev/drm Message-ID: <20090225.150516.708866590.imp@bsdimp.com> In-Reply-To: <20090225205253.GT19161@hoeg.nl> References: <20090225194228.GS19161@hoeg.nl> <1235593885.1273.80.camel@widget.2hip.net> <20090225205253.GT19161@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20090225205253.GT19161@hoeg.nl>
Ed Schouten <ed@80386.nl> writes:
: * Robert Noland <rnoland@FreeBSD.org> wrote:
: > On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
: > > Hi Robert,
: > >
: > > * Robert Noland <rnoland@FreeBSD.org> wrote:
: > > > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
: > > > + {0x8086, 0x2772}, /* Intel i945G */ \
: > > > + {0x8086, 0x27A2}, /* Intel i945GM */ \
: > > > + {0x8086, 0x27AE}, /* Intel i945GME */ \
: > > > + {0, 0}
: > > > +};
: > >
: > > Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
: > > definitions here?
: >
: > Where are those located? The rest of drm just uses the hex id's, if
: > there is a better way, I'm up for it.
:
: Oh wait, I always thought they were part of some kind of central list,
: like usbdevs, but it turns out device drivers just #define them
: themselves. Never mind.
NetBSD has this, but it was never adapted by FreeBSD.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090225.150516.708866590.imp>