Date: Sat, 13 Jul 2013 10:31:19 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: Craig Rodrigues <rodrigc@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marko Zec <zec@fer.hr> Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713073118.GC2757@gmail.com> In-Reply-To: <CAJ-VmomidFufKmGUb0YP2pHWu%2BpF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com> References: <201307120803.r6C83ACp016523@svn.freebsd.org> <CAJ-Vmonrmgr3HJRzQtVmWp=8SkpSeWNVeBZgOnSnE72NNp=3DQ@mail.gmail.com> <CAG=rPVcxvWq-MoXADiv%2BgLY-d3hhv1GTMO1R14bhLRm9UB9DqA@mail.gmail.com> <20130712202710.GB2757@gmail.com> <CAJ-Vmomv1nEEq9HV9GreQg6KJGos6ffDhFcVUsUuzfCL6h-YQw@mail.gmail.com> <CAJ-Vmokm29XXbQr5uTwEbGGDYo-8WQNsp60b%2B7Khkteyh%2BO%2B6A@mail.gmail.com> <CAJ-VmomidFufKmGUb0YP2pHWu%2BpF2Os3Fo4JWzkMJDKLqP_ing@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 12, 2013 at 10:40:08PM -0700, Adrian Chadd wrote: > Here's what I have running on my stable/9 VIMAGE laptop. > > http://people.freebsd.org/~adrian/ath/20130712-vimage-default-attach-detach.diff > > How's this look to put into -HEAD? Your patch looks similar to Marko's: http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20121115/0824ca85/attachment.diff Marko took your idea of setting vnet0 context in device_probe_and_attach(), although there is no is_default_vnet check, and I also think it is not necessary here -- just unconditionally set vnet0 is ok. Also, as I understand, after handling vnet context in device_probe_and_attach(), there is no need in curvnet setting in kldload/kldunload, and Marko removed it. In net/if.c, similarly to you, Marko sets vnet context in if_detach(), but also in if_free(), so this would be good to commit too (I suppose Marko had good reasons to do this). I can't comment the netgraph related parts of your patch as I have no idea what is going on here. Though I think this could be committed separately if it is needed. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130713073118.GC2757>