Date: Wed, 21 Oct 2015 15:15:01 +0300 From: Anton Yuzhaninov <citrin+bsd@citrin.ru> To: svn-src-head@freebsd.org Subject: Re: svn commit: r289664 - head/sys/kern Message-ID: <562781C5.4060408@citrin.ru> In-Reply-To: <5626A748.5040101@FreeBSD.org> References: <201510202038.t9KKcKW5064373@repo.freebsd.org> <5626A748.5040101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/20/15 23:42, Bryan Drewery wrote: > On 10/20/2015 1:38 PM, Konstantin Belousov wrote: >> Author: kib >> Date: Tue Oct 20 20:38:20 2015 >> New Revision: 289664 >> URL: https://svnweb.freebsd.org/changeset/base/289664 >> >> Log: >> Trim spaces at end of line to record the proper commit message for >> r289660: > > I really think we should just do a full revert and recommit in these > cases, and not even a forced commit. Neither this commit or a forced > commit will show in 'svn blame' or even during a bisect. It really just > becomes luck to find the right commit noting the message. IMHO 'svn > blame' is more important than some extra churn in 'svn log' or email. It > does add more steps in 'svn blame' but it ends up giving the right > message more obviously. > > I'm not asking to redo this commit now, but I think we should have a > standard of just recommitting to fix mistakes. Why svn propedit svn:log --revprop -r289660 Is not used? AFAIR this was disabled, because revprop edit can't be synced with CVS. But there is no official CVS repo for a log time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?562781C5.4060408>