Date: Thu, 4 Sep 2003 11:25:23 +0200 (CEST) From: Michal Mertl <mime@traveller.cz> To: Jens Rehsack <rehsack@liwing.de> Cc: current@freebsd.org Subject: Re: bktr(4) bufs plus patch Message-ID: <20030904101622.T32195@prg.traveller.cz> In-Reply-To: <3F56651C.5050108@liwing.de> References: <Pine.BSF.4.41.0212081046090.73179-200000@prg.traveller.cz> <3F56651C.5050108@liwing.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 3 Sep 2003, Jens Rehsack wrote:
> Michal Mertl wrote:
> > I found 2 bugs and some potential problems in bktr(4) code.
> >
> > Bug 1:
> > Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is
> > that code tries to use iicbus which isn't defined where it looks for
> > it. I added it there and the compilation and detection goes fine. I don't
> > know how to actually test it though.
> >
>
> [...]
>
> Will anyone responsible take notice of this patch and commit it?
>
> > ------------------------------------------------------------------------
> >
> > *** dev/bktr/bktr_reg.h.ori Sun Dec 8 10:40:14 2002
> > --- dev/bktr/bktr_reg.h Sun Dec 8 10:40:38 2002
> > ***************
> > *** 448,453 ****
> > --- 448,454 ----
> > struct bktr_i2c_softc {
> > int bus_owned;
> >
> > + device_t iicbus;
> > device_t iicbb;
> > device_t smbus;
> > };
> > *** dev/bktr/bktr_os.c.ori Sun Dec 8 10:39:13 2002
> > --- dev/bktr/bktr_os.c Sun Dec 8 10:39:35 2002
> > ***************
> > *** 499,513 ****
> > destroy_dev(bktr->tunerdev);
> > destroy_dev(bktr->bktrdev);
> >
> > - /* If this is unit 0, then destroy the alias entries too */
> > - #if (__FreeBSD_version >=500000)
> > - if (unit == 0) {
> > - destroy_dev(bktr->vbidev_alias);
> > - destroy_dev(bktr->tunerdev_alias);
> > - destroy_dev(bktr->bktrdev_alias);
> > - }
> > - #endif
> > -
> > /*
> > * Deallocate resources.
> > */
> > --- 499,504 ----
The destroy_dev calls for aliases have been removed in -current on 9th Dec
2002 (one day after I sent the email). See PR kern/36413. The fix hasn't
been MFCed but there's no need - the code is wrapped in '#if
(__FreeBSD_version >= 500000)'. The fix for BKTR_USE_FREEBSD_SMBUS hasn't
been commited.
I didn't send-pr but will recheck the status of things over the weekend
and perhaps will do.
To other readers: in my original email
(http://docs.freebsd.org/cgi/getmsg.cgi?fetch=2276+0+archive/2002/freebsd-current/20021215.freebsd-current)
I talked about another problem (limits on the maximum number of devices).
When I reread what I wrote at the time I have to say 'sorry for my
English' :-).
--
Michal Mertl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030904101622.T32195>