Date: Wed, 23 Jul 2003 18:04:19 -0400 From: Mike Makonnen <mtm@identd.net> To: Peter Wemm <peter@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_umtx.c Message-ID: <20030723220418.GA62833@kokeb.ambesa.net> In-Reply-To: <200307232029.h6NKTDHP031126@repoman.freebsd.org> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote:
> peter 2003/07/23 13:29:13 PDT
>
> FreeBSD src repository
>
> Modified files:
> sys/kern kern_umtx.c
> Log:
> Initialize 'blocked' to NULL. I think this was a real problem, but I
> am not sure about that. The lack of -Werror and the inline noise hid
> this for a while.
No, I don't think it was a problem. It does get initialized before
use in the same if.. statement it is compared in:
uq = umtx_lookup(td, umtx);
if (uq == NULL ||
(uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL &&
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It might be against style, though.
Cheers.
--
Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
mtm@identd.net | D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9
mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030723220418.GA62833>