Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Jun 2017 08:32:07 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Edward Tomasz Napierala <trasz@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r320360 - head/usr.bin/resizewin
Message-ID:  <1498487527.85102.5.camel@freebsd.org>
In-Reply-To: <201706261314.v5QDEfHj014897@repo.freebsd.org>
References:  <201706261314.v5QDEfHj014897@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2017-06-26 at 13:14 +0000, Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Mon Jun 26 13:14:41 2017
> New Revision: 320360
> URL: https://svnweb.freebsd.org/changeset/base/320360
> 
> Log:
>   Make resizewin(1) do flushing by using TCSAFLUSH instead of TCSANOW
>   followed by tcflush(3).  This works just as well and is more
> elegant.
>   
>   Suggested by:	bde
>   MFC after:	2 weeks
>   Sponsored by:	DARPA, AFRL
> 
> Modified:
>   head/usr.bin/resizewin/resizewin.c
> 
> Modified: head/usr.bin/resizewin/resizewin.c
> =====================================================================
> =========
> --- head/usr.bin/resizewin/resizewin.c	Mon Jun 26 13:11:21
> 2017	(r320359)
> +++ head/usr.bin/resizewin/resizewin.c	Mon Jun 26 13:14:41
> 2017	(r320360)
> @@ -91,20 +91,15 @@ main(int argc, char **argv)
>  			exit(0);
>  	}
>  
> -	/* Disable echo */
> +	/* Disable echo, drain the input, and flush the output */

This comment is backwards.  Draining happens to output, and flushing
happens to input.

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1498487527.85102.5.camel>