Date: Wed, 7 Jan 2026 16:19:34 -0500 From: Ed Maste <emaste@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rg_rav?= <des@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 27894e20f140 - main - libgeom: Fix segfault in 32-on-64 case Message-ID: <CAPyFy2CdnJ4bjAgHfD9EZ2OyLwi=ZiEdMwZ5%2BnZntSLaAOg8nA@mail.gmail.com> In-Reply-To: <cce035dc-ca9b-4dc0-81f7-22b92da52217@FreeBSD.org> References: <6958dd10.b4b9.2aebecda@gitrepo.freebsd.org> <cce035dc-ca9b-4dc0-81f7-22b92da52217@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Tue, 6 Jan 2026 at 09:37, John Baldwin <jhb@freebsd.org> wrote: > > Should we perhaps not use pointers to hold the cookies? This is going to truncate > in the lib32 case which will probably still work in practice as the low 32 bits of > kernel object addresses are probably unique, but isn't foolproof. Perhaps the cookie > values should be stored as either kvaddr_t values, or uintmax_t? I left a comment in the review that it would be good to at least have a comment in the code explaining the 32-bit truncation (that in practice they are probably unique).home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CdnJ4bjAgHfD9EZ2OyLwi=ZiEdMwZ5%2BnZntSLaAOg8nA>