Date: Tue, 6 Nov 2001 08:35:54 -0800 From: Murray Stokely <murray.stokely@windriver.com> To: Peter Pentchev <roam@ringlet.net> Cc: Murray Stokely <murray@FreeBSD.org>, doc@FreeBSD.org Subject: Re: TIDYFLAGS fixes all around the tree Message-ID: <20011106083554.W1818@windriver.com> In-Reply-To: <20011106125323.E10023@straylight.oblivion.bg>; from roam@ringlet.net on Tue, Nov 06, 2001 at 12:53:25PM %2B0200 References: <20011105175820.D77919@straylight.oblivion.bg> <20011105124156.D10872@windriver.com> <20011106125323.E10023@straylight.oblivion.bg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Tue, Nov 06, 2001 at 12:53:25PM +0200, Peter Pentchev wrote:
> Okay, so I was working from an 8-9 hours' old tree. Still, maybe
> I'm being dumb, but I do not really see the point of the fix you
> committed. It definitely does not fix the problem I reported,
> as seen by:
>
> [roam@straylight:v4 ~/fbsd/r/doc/ru_RU.KOI8-R/articles/explaining-bsd]$ make -V TIDYFLAGS
> -latin1
>
> As you can see, still no -m :(
[amd] /usr/doc/ru_RU.KOI8-R/articles/explaining-bsd> make TIDYFLAGS=-latin1
[ jade output snipped ]
/usr/local/bin/tidy -i -m -f /dev/null -latin1 article.html
Can't open "/export/home/murray/.tidyrc"
*** Error code 1 (ignored)
Seems to be working now.
TIDYFLAGS is the user settable variable for additional flags to tidy,
while 'TIDYOPTS' is the internal makefile variable for the complete
set of flags to tidy.
TIDYOPTS= <defaults> ${TIDYFLAGS}
> As I already said, I do not see the point of 'VAR?= blah ${VAR}'.
TIDY?= ${PREFIX}/bin/tidy
TIDYOPTS?= -i -m -f /dev/null ${TIDYFLAGS}
This is not a case of VAR?= blah ${VAR}. It is a case of B?= bla ${A}
> This statement only ever changes the value of VAR if VAR *is not set*.
> In that case, ${VAR} is empty, and VAR is set to 'blah'. If VAR is
> already set, then this statement will have absolutely no effect :)
I agree. If you find a case like that in our makefiles, please fix
it. ;)
- Murray
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (SunOS)
Comment: For info see http://www.gnupg.org
iD8DBQE76BFptNcQog5FH30RAoRUAJ0WOS+GDc3PbxpriRL4osKXzzoShQCfXzAh
2cvgbQL68QUrfKEUWJKzmoY=
=zZ1K
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011106083554.W1818>