Date: Fri, 3 May 2024 17:24:19 +0200 (CEST) From: Ronald Klop <ronald-lists@klop.ws> To: Ronald Klop <ronald-lists@klop.ws> Cc: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh <imp@FreeBSD.org>, dev-commits-src-main@FreeBSD.org Subject: Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM Message-ID: <304810585.11110.1714749859580@localhost> In-Reply-To: <1010899452.10421.1714749653185@localhost> References: <202405031447.443ElgZj051266@gitrepo.freebsd.org> <1010899452.10421.1714749653185@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_11109_906100372.1714749859553 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Ah. Found https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277673 in your next commit. Cheers, Ronald. Van: Ronald Klop <ronald-lists@klop.ws> Datum: vrijdag, 3 mei 2024 17:20 Aan: Warner Losh <imp@FreeBSD.org> CC: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org Onderwerp: Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM > > Are you sure you used the right PR? > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277637 > "[NEW PORT] security/enc: Modern and friendly CLI alternative to GnuPG" > > > Regards, > Ronald. > > > Van: Warner Losh <imp@FreeBSD.org> > Datum: vrijdag, 3 mei 2024 16:47 > Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org > Onderwerp: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM >> >> The branch main has been updated by imp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=12117d0e9314d1706508386c1c49ace2de578b31 >> >> commit 12117d0e9314d1706508386c1c49ace2de578b31 >> Author: Matthew Grooms <mgrooms@shrew.net> >> AuthorDate: 2024-05-03 14:41:05 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2024-05-03 14:46:59 +0000 >> >> da: Update trim stats for WRITE SAME and ATA TRIM >> >> The scsi UNMAP path updated trim stats in the da sysctl, but the ATA >> TRIM passthru and WRITE SAME paths did not. Add code so they do. >> >> PR: 277637 >> Reviewed by: imp (tweaked WS path to update ranges) >> --- >> sys/cam/scsi/scsi_da.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c >> index 9b3d706d6168..0daaff9229b0 100644 >> --- a/sys/cam/scsi/scsi_da.c >> +++ b/sys/cam/scsi/scsi_da.c >> @@ -4208,6 +4208,9 @@ da_delete_trim(struct cam_periph *periph, union ccb *ccb, struct bio *bp) >> da_default_timeout * 1000); >> ccb->ccb_h.ccb_state = DA_CCB_DELETE; >> ccb->ccb_h.flags |= CAM_UNLOCKED; >> + softc->trim_count++; >> + softc->trim_ranges += ranges; >> + softc->trim_lbas += block_count; >> cam_iosched_submit_trim(softc->cam_iosched); >> } >> >> @@ -4268,6 +4271,9 @@ da_delete_ws(struct cam_periph *periph, union ccb *ccb, struct bio *bp) >> da_default_timeout * 1000); >> ccb->ccb_h.ccb_state = DA_CCB_DELETE; >> ccb->ccb_h.flags |= CAM_UNLOCKED; >> + softc->trim_count++; >> + softc->trim_ranges++; >> + softc->trim_lbas += count; >> cam_iosched_submit_trim(softc->cam_iosched); >> } >> >> >> >> >> > > ------=_Part_11109_906100372.1714749859553 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit <html><head></head><body>Ah.<br> <br> Found https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277673 in your next commit.<br> <br> Cheers,<br> Ronald.<br> <br> <p><strong>Van:</strong> Ronald Klop <ronald-lists@klop.ws><br> <strong>Datum:</strong> vrijdag, 3 mei 2024 17:20<br> <strong>Aan:</strong> Warner Losh <imp@FreeBSD.org><br> <strong>CC:</strong> dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org<br> <strong>Onderwerp:</strong> Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM</p> <blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px"> <div class="MessageRFC822Viewer" id="P"> <div class="MultipartAlternativeViewer"> <div class="TextHTMLViewer" id="P.P.P">Are you sure you used the right PR?<br> <br> <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277637">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277637</a><br>; "<span id="summary_container"><span id="short_desc_nonedit_display">[NEW PORT] security/enc: Modern and friendly CLI alternative to GnuPG"<br> <br> <br> Regards,<br> Ronald.</span></span><br> <br> <p><strong>Van:</strong> Warner Losh <imp@FreeBSD.org><br> <strong>Datum:</strong> vrijdag, 3 mei 2024 16:47<br> <strong>Aan:</strong> src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org<br> <strong>Onderwerp:</strong> git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM</p> <blockquote style="padding-right: 0px; padding-left: 5px; margin-left: 5px; border-left: #000000 2px solid; margin-right: 0px"> <div class="MessageRFC822Viewer" id="P"> <div class="TextPlainViewer" id="P.P">The branch main has been updated by imp:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=12117d0e9314d1706508386c1c49ace2de578b31">https://cgit.FreeBSD.org/src/commit/?id=12117d0e9314d1706508386c1c49ace2de578b31</a><br>; <br> commit 12117d0e9314d1706508386c1c49ace2de578b31<br> Author: Matthew Grooms <mgrooms@shrew.net><br> AuthorDate: 2024-05-03 14:41:05 +0000<br> Commit: Warner Losh <imp@FreeBSD.org><br> CommitDate: 2024-05-03 14:46:59 +0000<br> <br> da: Update trim stats for WRITE SAME and ATA TRIM<br> <br> The scsi UNMAP path updated trim stats in the da sysctl, but the ATA<br> TRIM passthru and WRITE SAME paths did not. Add code so they do.<br> <br> PR: 277637<br> Reviewed by: imp (tweaked WS path to update ranges)<br> ---<br> sys/cam/scsi/scsi_da.c | 6 ++++++<br> 1 file changed, 6 insertions(+)<br> <br> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c<br> index 9b3d706d6168..0daaff9229b0 100644<br> --- a/sys/cam/scsi/scsi_da.c<br> +++ b/sys/cam/scsi/scsi_da.c<br> @@ -4208,6 +4208,9 @@ da_delete_trim(struct cam_periph *periph, union ccb *ccb, struct bio *bp)<br> da_default_timeout * 1000);<br> ccb->ccb_h.ccb_state = DA_CCB_DELETE;<br> ccb->ccb_h.flags |= CAM_UNLOCKED;<br> + softc->trim_count++;<br> + softc->trim_ranges += ranges;<br> + softc->trim_lbas += block_count;<br> cam_iosched_submit_trim(softc->cam_iosched);<br> }<br> <br> @@ -4268,6 +4271,9 @@ da_delete_ws(struct cam_periph *periph, union ccb *ccb, struct bio *bp)<br> da_default_timeout * 1000);<br> ccb->ccb_h.ccb_state = DA_CCB_DELETE;<br> ccb->ccb_h.flags |= CAM_UNLOCKED;<br> + softc->trim_count++;<br> + softc->trim_ranges++;<br> + softc->trim_lbas += count;<br> cam_iosched_submit_trim(softc->cam_iosched);<br> }<br> <br> </div> <hr></div> </blockquote> <br> </div> </div> </div> </blockquote> <br> </body></html> ------=_Part_11109_906100372.1714749859553--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?304810585.11110.1714749859580>