Date: Sat, 14 Jan 2012 17:27:33 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/pdflib Makefile pkg-plist ports/print/pdflib/files patch-configure ports/print/pdflib-perl Makefile Message-ID: <20120114092733.GA45406@bonjour.sunpoet.net> In-Reply-To: <201201130917.q0D9HfbF078269@repoman.freebsd.org> References: <201201130917.q0D9HfbF078269@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 13, 2012 at 09:17:41AM +0000, Alex Dupre wrote:
> ale 2012-01-13 09:17:41 UTC
>
> FreeBSD ports repository
>
> Modified files:
> print/pdflib Makefile pkg-plist
> print/pdflib-perl Makefile
> Added files:
> print/pdflib/files patch-configure
> Log:
> - Add forgotten patch
> - Switch to OPTIONS
> - Add Java bindings [1]
>
> Submitted by: Oliver Brandmueller <ob@e-Gitt.NET> [1]
>
> Revision Changes Path
> 1.4 +1 -1 ports/print/pdflib-perl/Makefile
> 1.61 +29 -9 ports/print/pdflib/Makefile
> 1.9 +12 -0 ports/print/pdflib/files/patch-configure (new)
> 1.22 +5 -0 ports/print/pdflib/pkg-plist
Hi Alex,
I was confused by the conditional PERL OPTIONS.
.if defined(WITH_PERL)
OPTIONS= PERL "Build perl bindings" on
.else
OPTIONS= PERL "Build perl bindings" off
.endif
If WITH_PERL defined somewhere (pdflib-perl, make.conf or portconf),
the perl option should already be turned on by options framework. It
seems that a default-off perl option (line 4) is enough.
Regards,
--
Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120114092733.GA45406>