Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Nov 2022 09:42:13 +0900
From:      Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
To:        Mark Millard <marklmi@yahoo.com>
Cc:        Warner Losh <imp@bsdimp.com>, "Patrick M. Hausen" <pmh@hausen.com>, Alexander Leidinger <Alexander@leidinger.net>, tsoome@freebsd.org, Li-Wen Hsu <lwhsu@freebsd.org>, current@freebsd.org
Subject:   Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)
Message-ID:  <20221110094213.7c3d5a2bd2422b0b89ce4d12@dec.sakura.ne.jp>
In-Reply-To: <EDDCAAA5-E192-414A-9262-4ABADECB8163@yahoo.com>
References:  <202211070339.2A73dJlO027991@gitrepo.freebsd.org> <20221107121514.Horde.nulS9Wg1s3yzAsXXkuJRBa9@webmail.leidinger.net> <CANCZdfrdc%2BDbv6sDyDLcWNpXnWScEmpUsGu3q8%2BMbZRjDS8eig@mail.gmail.com> <20221108105053.Horde.eqgFiBJe2ngGAj6BkXcv5-Z@webmail.leidinger.net> <20221109134610.Horde.JB7ibQTWprHbmIUfhg7JY7f@webmail.leidinger.net> <CANCZdfptmipq%2BsS0AQ1%2B7EmLT-7YdKv8s%2BnCV7ON1Qy6-C6N9A@mail.gmail.com> <460205F9-5D59-4033-813B-C34E01BFD6C4@hausen.com> <CANCZdfoeDvxSqqEjpnfK=FCY0K1aYEqTw80SKLAZ-5d2qrW5EA@mail.gmail.com> <AFF06A1C-A58F-40E7-9A21-A585F95E447D@hausen.com> <CANCZdfq0Q67tqE-6%2BSjbdJVH_p0oMh5Xz_bW=SWWM%2BhWnDLZYw@mail.gmail.com> <EDDCAAA5-E192-414A-9262-4ABADECB8163@yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 Nov 2022 14:12:21 -0800
Mark Millard <marklmi@yahoo.com> wrote:

> On Nov 9, 2022, at 12:56, Warner Losh <imp@bsdimp.com> wrote:
> 
> > On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen <pmh@hausen.com> wrote:
> > 
> > > Am 09.11.2022 um 21:51 schrieb Warner Losh <imp@bsdimp.com>:
> > > Yes. For safety, boot loader upgrade is mandatory when you do a zpool upgrade of the root filesystem.
> > > It was definitely needed in the OpenZFS jump, and we've had one or two other flag days since.
> > 
> > That's a given and not a problem. What I fear from my understanding of this thread so far is
> > that there might be a situation when I upgrade the zpool and the boot loader and the system
> > ends up unbootable nonetheless.
> > 
> > Possible or not?
> > 
> > If all you do is upgrade, then no, modulo bugs that we've thankfully not had yet.
> 
> I guess you mean FreeBSD upgrade, not zpool updgrade?
> 
> For zpool upgrade after a main [so: 14] FreeBSD upgrade . . .
> 
> As I understand it, com.delphix:head_errlog was not added to
> the loader until after some folks had done a zpool upgrade
> and then could not boot. The loader was updated in response
> to the people's problem with trying to boot.
> 
> Of course, this was main, not stable or releng/13.* or the
> like. There is more control over the staging of updates
> for them.

Unfortunately, sometimes adding X-MFC-WITH is forgotton on follow-up
commits, making the commit NOT MFC'ed to stable/* and fire there again.

And unfortunately, even though X-MFC-WITH is added, sometimes MFC is
missed.


> It would be nice if UPDATING reported when a openzfs update
> was adding new zpool feature(s) to main and if the loader
> was ready for them yet. If not: Later adding an entry for
> the loader being ready for the feature(s).

+1.


> > It's when you enable something on the zpool that you can run into trouble, but that's true independent of upgrade :)
> > 
> > Warner
> >   Modulo bugs, try test systems first, etc. Of course.
> > 
> 
> ===
> Mark Millard
> marklmi at yahoo.com
> 
> 
> 


-- 
Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221110094213.7c3d5a2bd2422b0b89ce4d12>