Date: Thu, 10 May 2018 09:57:13 -0400 From: Ed Maste <emaste@freebsd.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333457 - head/sys/kern Message-ID: <CAPyFy2BB-puR9pEdNnO35XKjcp9pe7DYfF_RcFV_fvhfPg3HPg@mail.gmail.com> In-Reply-To: <c9c7d12f-0624-80fd-5e4d-5e829335fbb5@cs.duke.edu> References: <201805101136.w4ABaG7G034274@repo.freebsd.org> <c9c7d12f-0624-80fd-5e4d-5e829335fbb5@cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 May 2018 at 09:18, Andrew Gallatin <gallatin@cs.duke.edu> wrote: > On 05/10/18 07:36, Ed Maste wrote: >> >> Author: emaste >> Date: Thu May 10 11:36:16 2018 >> New Revision: 333457 >> URL: ... >> >> Log: >> ANSIfy sys_generic.c > > This breaks the kernel build: > > /usr/src/sys/kern/sys_generic.c:522:1: error: conflicting types for > 'kern_pwritev' > kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset) > ^ > /usr/src/sys/sys/syscallsubr.h:212:5: note: previous declaration is here > int kern_pwritev(struct thread *td, int fd, struct uio *auio, off_t > offset); > ^ > 1 error generated. > *** [sys_generic.o] Error code 1 Sorry about the breakage, and thanks for reporting and fixing. I merged from FreeBSD to my WIP tree, and was reminded that I had this change because r333425 included an adjacent change. When making the change in svn I accidentally reintroduced the misordering.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BB-puR9pEdNnO35XKjcp9pe7DYfF_RcFV_fvhfPg3HPg>