Date: Mon, 4 Mar 2013 21:17:30 +0100 From: Davide Italiano <davide@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-projects@freebsd.org, Attilio Rao <attilio@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r247710 - projects/calloutng/sys/kern Message-ID: <CACYV=-HXz2eaCHkA6MhCR1H1Lb7uyASCQd6k-7zYVa46i%2Bvq-g@mail.gmail.com> In-Reply-To: <201303041040.41845.jhb@freebsd.org> References: <201303031339.r23DdsBU047737@svn.freebsd.org> <201303041040.41845.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 4, 2013 at 4:40 PM, John Baldwin <jhb@freebsd.org> wrote: > On Sunday, March 03, 2013 8:39:54 am Davide Italiano wrote: >> Author: davide >> Date: Sun Mar 3 13:39:54 2013 >> New Revision: 247710 >> URL: http://svnweb.freebsd.org/changeset/base/247710 >> >> Log: >> - Use TRUE/FALSE in lieu of 0/1 for boolean_t variables. > > We have stdbool in the kernel. Why not use that instead of the Machish > boolean_t? > > -- > John Baldwin It was originally int, and a couple of days ago Attilio suggested to move to 'boolean_t'. Honestly, I didn't argue due to the relative little relevance of the change, but actually I find the type change more explicative. I have no strong objections to change it again (in particular because I think you're suggesting to use bool to be C99 compliant, feel free to correct me if I'm wrong). While here. After closer looking I realized boolean_t is widely used in the kernel (e.g. sys/kern/). Is this just a common error or is there something I'm missing? Thanks -- Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-HXz2eaCHkA6MhCR1H1Lb7uyASCQd6k-7zYVa46i%2Bvq-g>