Date: Sun, 8 Oct 2023 00:36:48 +0300 From: Christos Margiolis <christos@freebsd.org> To: Dima Panov <fluffy@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9e589b093857 - main - tty: fix improper backspace behaviour for UTF8 characters when in canonical mode Message-ID: <q3wr3hjjr7onaian2iwlu3vnka2clxt5k5g3i5q3j3tno7vbs4@7rrnulibhjxy> In-Reply-To: <816f8408-865a-488f-a139-ad4bae2301fb@FreeBSD.org> References: <202310071800.397I0p9G047831@gitrepo.freebsd.org> <816f8408-865a-488f-a139-ad4bae2301fb@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Dima Panov wrote: > It breaks the build %( > > > In file included from /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken.c:70: > /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken_wcwidth.h:132:7: error: call to undeclared function 'bitcount'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > if (bitcount(bytes[0] & 0xf0) != nbytes) > ^ > 1 error generated. > *** [teken.o] Error code 1 The cross builds had succeeded on GitHub's Actions, our local machines and the FreeBSD cluster, so we thought it was good to go. Apparently, the code should call __bitcount() which is defined in sys/types.h (included in teken/teken.h), instead of bitcount(), which is defined in sys/libkern.h and is not included. I am pushing a fix right now. Unfortunately, since all the machines I keep trying to clean build on succeed, we'll have to wait for feedback again to be sure that the fix is working... Christoshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?q3wr3hjjr7onaian2iwlu3vnka2clxt5k5g3i5q3j3tno7vbs4>