Date: Thu, 9 Oct 2003 07:21:06 -0700 From: Sam Leffler <sam@errno.com> To: Alexey Dokuchaev <danfe@nsu.ru>, Sam Leffler <sam@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/hifn hifn7751.c hifn7751reg.h hifn7751var.h Message-ID: <200310090721.07096.sam@errno.com> In-Reply-To: <20031009063900.GB57459@regency.nsu.ru> References: <200310082352.h98Nq0ws011528@repoman.freebsd.org> <20031009063900.GB57459@regency.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 08 October 2003 11:33 pm, Alexey Dokuchaev wrote: > On Wed, Oct 08, 2003 at 01:25:47PM -0700, Sam Leffler wrote: > > sam 2003/10/08 13:25:47 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/hifn hifn7751.c hifn7751reg.h hifn7751var.h > > Log: > > Add symmetric crypto support for the 7955 and 7956. > > Hmm, time to rename those hifn7751* files, or does 7751 denote something t> hat 7955 and 7956 are based on? The code is shared with openbsd so the filenames will not change. On Wednesday 08 October 2003 11:39 pm, Alexey Dokuchaev wrote: > On Wed, Oct 08, 2003 at 04:52:00PM -0700, Sam Leffler wrote: > > sam 2003/10/08 16:52:00 PDT > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_4) > > sys/dev/hifn hifn7751.c hifn7751reg.h hifn7751var.h > > Log: > > MFC 7955/7956 symmetric crypto support > > Hmm, had this stuff been extensively tested to be insta-MFCed, > especially considering we're so close to 4.9-RELEASE and, just as you > said, it's performance being currently suboptimal? The performance of devices other than 7955 and 7956 is unchanged. Only the new devices perform suboptimally. Without these changes these devices will not work at all. Adding the support now, even if suboptimal, means folks can apply a simple patch to fix the performance issue. > > I've always been under impression that -STABLE should probably stay out > of such treatments. I tested carefully because of this. This driver is optional so I considered the risk worthwhile. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310090721.07096.sam>