Date: Wed, 1 Oct 2025 06:49:37 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Kevin Irabor <kevin.irabor04@gmail.com> Cc: Kristof Provost <kp@freebsd.org>, ItzBlinkzy <kitey13579@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Message-ID: <aN0xccn6VBcTPzOs@cell.glebi.us> In-Reply-To: <CABmcMp0tgu161k71rdK8rgM-wzzFV-k-Nr_ccH78SwxA7gfaWw@mail.gmail.com> References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> <aNwVz6wL5cLbmYqR@cell.glebi.us> <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> <aNwdPbnDvkBA0mQ1@cell.glebi.us> <D992AE7A-1BB5-4630-8A2E-35E0EA6B8782@FreeBSD.org> <CABmcMp0tgu161k71rdK8rgM-wzzFV-k-Nr_ccH78SwxA7gfaWw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 01, 2025 at 09:27:05AM +0100, Kevin Irabor wrote: K> Hello, K> Both emails are mine - one I use as my GitHub email and the one I signed K> off with is my personal email. Sorry for the confusion there. K> To answer your questions: K> I was browsing the ifnet code and saw the earlier IfAPI commits that were K> made. I assumed the pattern was to provide accessors for every field in K> struct ifnet, and to maintain consistency I added this one since it was K> missing. K> I'm not aware of any drivers that need if_home_vnet and if_vmove Thanks Kevin! I'd suggest to revert the change as we don't expect any driver to ever use this field. And if one uses, that would be a problem. If you want to help with current state of IfAPI, then there is a task to categorize the existing accessors into few groups: - those that all NIC drivers use - those that a few NIC drivers use - those that in-stack drivers (e.g. vlan(4), lagg(4), etc) use - those that no one uses A minimal documentation (a comment in the source code) with the results of this categorization will be helpful. And jumping forward, I would suggest to remove the accessors that belong to class 4 - no one uses. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aN0xccn6VBcTPzOs>