Date: Fri, 3 Dec 2010 11:52:01 -0500 From: David Schultz <das@FreeBSD.ORG> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r209110 - in head/lib/msun: . src Message-ID: <20101203165201.GA36319@zim.MIT.EDU> In-Reply-To: <20101203005417.GZ2392@deviant.kiev.zoral.com.ua> References: <201006121732.o5CHW5Cs065722@svn.freebsd.org> <20100615084939.GL13238@deviant.kiev.zoral.com.ua> <20100615131443.GA93094@zim.MIT.EDU> <20101202045728.GA19295@zim.MIT.EDU> <20101202095652.GQ2392@deviant.kiev.zoral.com.ua> <20101202190010.GB28587@zim.MIT.EDU> <20101203005417.GZ2392@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 03, 2010, Kostik Belousov wrote:
> On Thu, Dec 02, 2010 at 02:00:10PM -0500, David Schultz wrote:
> > On Thu, Dec 02, 2010, Kostik Belousov wrote:
> > > For __isnanf, libc exports __isnanf@FBSD_1.0, and libm exports
> > > __isnanf@FBSD_1.2. I suspect that we could export both
> > > __isnanf@FBSD_1.0 and __isnanf@FBSD_1.2 from libc.
> >
> > I like the idea of adding an __isnanf@FBSD_1.2 alias to libc for
> > the benefit of people running -CURRENT.
>
> Ok, draft of the change is below, I am not sure is it worth the churn.
>
> I was unable to make the ld support two versions of the same symbol.
> lib/msun would benefit from elimination of isnan sources if this is
> committed.
[...]
> --- /dev/null
> +++ b/lib/libc/gen/isnan_compat.c
> @@ -0,0 +1,17 @@
> +/*
> + * The file is in public domain.
> + * Written by Konstantin Belousov <kib@FreeBSD.org>
> + *
> + * $FreeBSD$
> + */
> +
> +#include <math.h>
> +
> +__sym_compat(__isnanf, __isnanf_compat, FBSD_1.0);
> +
> +int
> +__isnanf_compat(float f)
> +{
> +
> + return (__isnanf(f));
> +}
Thanks. Hmm... if it ultimately entails replacing a small amount
of cruft in libm with a small amount of cruft in libc, it's
probably not worth the churn.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101203165201.GA36319>