Date: Wed, 20 Apr 2016 07:41:41 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, araujo@freebsd.org, John Baldwin <jhb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 Message-ID: <CAG6CVpUnbsgJUbZQzrtWN9mTX3_XBEpQ2ObmcjfF9WjpC9dZCA@mail.gmail.com> In-Reply-To: <c53f4273-d84a-0321-5ba0-d8f99ac6366a@FreeBSD.org> References: <201604190446.u3J4kD9G050780@repo.freebsd.org> <4114217.PtcV9LDMal@ralph.baldwin.cx> <CAOfEmZhofgYySTtMKAXo-Qkm8BRaOP8kzEfchdtPTH3T-0W-qQ@mail.gmail.com> <20160420115844.Y967@besplex.bde.org> <c53f4273-d84a-0321-5ba0-d8f99ac6366a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni <pfg@freebsd.org> wrote: > One of the things I dislike is that most of the macros are in > lowercase. Lowercase would make sense if these were inline functions > but inline functions have disadvantages for these use cases. > OTOH, if they were uppercase, they would not be very easy on the eyes, > which is the current advantage. You bring up a good point. Obviously nitems() can't be an inline function, but roundup2() and friends could. Is there any reason not to change them over to inline functions? Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUnbsgJUbZQzrtWN9mTX3_XBEpQ2ObmcjfF9WjpC9dZCA>