Date: Thu, 23 May 2002 17:21:49 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern_mutex.c Message-ID: <20020523171421.L12695-100000@gamplex.bde.org> In-Reply-To: <200205222032.g4MKWdl17723@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 May 2002, John Baldwin wrote: > jhb 2002/05/22 13:32:39 PDT > > Modified files: > sys/i386/include cpufunc.h > sys/kern kern_mutex.c > Log: > Rename pause() to ia32_pause() so it doesn't conflict with the pause() > function defined in <unistd.h>. I didn't #ifdef _KERNEL it because the > mutex implementation in libpthread will probably need this. This shoots the messenger. The main bug is gross namespace pollution in <vgl.h>: %%% #ifndef _VGL_H_ #define _VGL_H_ #include <stdlib.h> #include <unistd.h> #include <string.h> #include <machine/cpufunc.h> %%% <machine/cpufunc.h> is really a kernel-only header, but it sometimes gets abused in userland. I think this shouldn't be supported. It contains mostly very machine-dependent interfaces, so it should be used in at most the implementation of libvgl. libvgl uses i386 interfaces unconditionally, so it only works on i386's, but this limitation is not documented. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020523171421.L12695-100000>