Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Dec 2016 08:39:09 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        Ravi Pokala <rpokala@mac.com>
Cc:        Alexander Kabaev <kan@freebsd.org>,  "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r310789 - head/lib/libpam/static_libpam
Message-ID:  <CAPyFy2AbsAgBR3zO0ng45z7fT4A7XFuv5rASd0P6VKOqWHfdBQ@mail.gmail.com>
In-Reply-To: <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com>
References:  <201612292130.uBTLUqus011628@repo.freebsd.org> <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29 December 2016 at 19:59, Ravi Pokala <rpokala@mac.com> wrote:
>
> I'm a little confused - the original version had to have had a compile-on=
ly step to generate the object first, before running the link-only operatio=
n against the object. The new code replaces the link-only operation with a =
compile+link operation. Shouldn't the pre-existing compile-only operation b=
e removed, since the new compile+link operation supersedes it?

Hi Ravi,

This change:

>> -     ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC}
>> +     ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.=
ALLSRC}

is not actually compiling, it's just invoking the compiler driver to
in turn invoke the linker. The input in ${.ALLSRC} is still a
collection of object files.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2AbsAgBR3zO0ng45z7fT4A7XFuv5rASd0P6VKOqWHfdBQ>