Date: Fri, 6 Feb 2015 21:31:55 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: James Gritton <jamie@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r278323 - in head: etc/rc.d usr.sbin/jail Message-ID: <C1CB8412-0FE4-4C8F-B238-1EEB8B584780@gmail.com> In-Reply-To: <609da07b7a80b4a59fce8655370b045e@gritton.org> References: <201502061754.t16HssXU042750@svn.freebsd.org> <C12F653F-5697-4219-9BE6-838C5278DC09@gmail.com> <609da07b7a80b4a59fce8655370b045e@gritton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Feb 6, 2015, at 21:27, James Gritton <jamie@freebsd.org> wrote: > On 2015-02-06 22:18, Garrett Cooper wrote: >> On Feb 6, 2015, at 9:54, Jamie Gritton <jamie@freebsd.org> wrote: >>> Modified: head/usr.sbin/jail/command.c >>> ============================================================================== >>> --- head/usr.sbin/jail/command.c Fri Feb 6 17:43:13 2015 (r278322) >>> +++ head/usr.sbin/jail/command.c Fri Feb 6 17:54:53 2015 (r278323) >>> @@ -112,6 +112,12 @@ next_command(struct cfjail *j) >>> if (!bool_param(j->intparams[IP_MOUNT_FDESCFS])) >>> continue; >>> j->comstring = &dummystring; >>> + break; >>> + case IP_MOUNT_PROCFS: >>> + if (!bool_param(j->intparams[IP_MOUNT_PROCFS])) >>> + continue; >>> + j->comstring = &dummystring; >>> + break; >> Did you intend on adding another break? The code would previously fall >> through to the next case statement... >>> case IP__OP: >>> case IP_STOP_TIMEOUT: >>> j->comstring = &dummystring; > > Yes. The code did indeed previously fall to the next case, but it was a no-op: the next case only had the same exact assignment that had just taken place (j->comstring = &dummystring). The lack of a break that had existed before was just some sloppy coding that I didn't notice at the time because it didn't actually change any behavior. Nonetheless it seemed worth correcting when I noticed it. True. I looked at the code afterwards and it looks ok. mount.procfs doesn’t exist in my environment. Is that command correct? $ which mount.procfs; echo $? 1 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU1aNLAAoJEMZr5QU6S73eJWoH/1d0mHer/sj8l48uf+qzX5EX OiKi+i6ScqMMcwUb43wPFkfv8ItCB9nmVW46y1++wOq+dbgUz91zU1/WyWER+YQv Z6NOjwMv3XwkV3l5VXR9h9e2pFYWx/ang7pR/o8pe8LFWCOLipEkZ0qyi2vg82bQ DyxYvzrlkqva7kH+2BY1+mji18oo7lb1IToYUj7Q+yZPwAwk6N8BdpIz/keCkU1d tJWCQU9r04wq+4nt1rjGRkWBi4z2wZrFiASuQIDZ/P22ZKsywq2HpZT1QvlhY/GQ HeoGs84r8lK0JgVNnfjNRFbHE+UffrPdSC2QbOKLltMooxfjTPFa9J1NQa6wrc4= =V7M3 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C1CB8412-0FE4-4C8F-B238-1EEB8B584780>