Date: Sat, 10 Apr 2004 20:48:12 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: noackjr@alumni.rice.edu Cc: Putinas Piliponis <putinas.piliponis@icnspot.net> Subject: Re: LOR: sys/kern/sys_generic.c:902 sys/fs/specfs/spec_vnops.c:387 Message-ID: <11273.1081622892@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 10 Apr 2004 12:54:14 CDT." <1747.192.168.1.9.1081619654.squirrel@www.noacks.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <1747.192.168.1.9.1081619654.squirrel@www.noacks.org>, "Jon Noack" w
rites:
Can you try this workaround ?
Index: spec_vnops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/specfs/spec_vnops.c,v
retrieving revision 1.220
diff -u -r1.220 spec_vnops.c
--- spec_vnops.c 7 Apr 2004 20:46:02 -0000 1.220
+++ spec_vnops.c 10 Apr 2004 18:47:32 -0000
@@ -382,9 +382,9 @@
("spec_poll() on un-referenced dev_t (%s)", devtoname(dev)));
cdevsw_ref(dsw);
if (!(dsw->d_flags & D_NEEDGIANT)) {
- DROP_GIANT();
+ /* XXX: not yet DROP_GIANT(); */
error = dsw->d_poll(dev, ap->a_events, ap->a_td);
- PICKUP_GIANT();
+ /* XXX: not yet PICKUP_GIANT(); */
} else
error = dsw->d_poll(dev, ap->a_events, ap->a_td);
cdevsw_rel(dsw);
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11273.1081622892>