Date: Sun, 17 Nov 2013 21:40:01 GMT From: Eitan Adler <lists@eitanadler.com> To: vbox@FreeBSD.org Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Message-ID: <201311172140.rAHLe1RO009779@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/182468; it has been noted by GNATS. From: Eitan Adler <lists@eitanadler.com> To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= <decke@bluelife.at>, bug-followup <bug-followup@freebsd.org>, Peter Jeremy <peter@rulingia.com> Cc: vbox@freebsd.org Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Date: Sun, 17 Nov 2013 16:32:46 -0500 On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fr=C3=B6hlich <decke@bluelife.at>= wrote: > The following reply was made to PR ports/182468; it has been noted by GNA= TS. > > From: =3D?ISO-8859-1?Q?Bernhard_Fr=3DF6hlich?=3D <decke@bluelife.at> > To: bug-followup@FreeBSD.org, peter@rulingia.com > Cc: > Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/v= irtualbox-ose > Date: Wed, 13 Nov 2013 13:31:49 +0100 > > I think the idea and approach is correct but I went for a slighly more > conservative > approach if _GCC_RUNTIME was not set which is true in case base gcc is u= sed=3D This can not possibly be correct as the variable begins with a "_". The initial proposed patch is also incorrect for a similar reason. _GCC_RUNTIME is not valid for use in a ports Makefile. Perhaps it would help if USE_GCC or USES=3Dcompiler exposed a variable indicating the runtime? --=20 Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311172140.rAHLe1RO009779>