Date: Mon, 11 Jan 2021 11:05:29 -0800 From: Ryan Libby <rlibby@freebsd.org> To: Hans Petter Selasky <hselasky@freebsd.org>, Vladimir Kondratyev <wulf@freebsd.org>, John Baldwin <jhb@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 16079c7233be - main - hid: quiet -Wswitch Message-ID: <CAHgpiFxxWvskdf9PyDkB4mhf6c=%2BBKGnhVMH1iTLB6su_tzqXg@mail.gmail.com> In-Reply-To: <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org> References: <202101110554.10B5sW2q070743@gitrepo.freebsd.org> <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 11, 2021 at 10:04 AM John Baldwin <jhb@freebsd.org> wrote: > > On 1/10/21 9:54 PM, Ryan Libby wrote: > > The branch main has been updated by rlibby: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370 > > > > commit 16079c7233be8bd6c88e3421a70c7ca87cfea370 > > Author: Ryan Libby <rlibby@FreeBSD.org> > > AuthorDate: 2021-01-11 05:53:15 +0000 > > Commit: Ryan Libby <rlibby@FreeBSD.org> > > CommitDate: 2021-01-11 05:53:15 +0000 > > > > hid: quiet -Wswitch > > > > Gcc builds complained that not all switch cases are handled. Add > > default cases to appease gcc. > > > > Reviewed by: hselasky (previous version), wulf > > Sponsored by: Dell EMC Isilon > > Differential Revision: https://reviews.freebsd.org/D28082 > > If these cases are never reachable, then I think '__assert_unreachable()' > is preferred to a plain break. > > -- > John Baldwin I'll have to let wulf and hselasky speak to that...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFxxWvskdf9PyDkB4mhf6c=%2BBKGnhVMH1iTLB6su_tzqXg>