Date: Fri, 16 Nov 2018 23:10:47 +0000 From: Brooks Davis <brooks@freebsd.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Brooks Davis <brooks@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338990 - in head/sys: compat/freebsd32 dev/pci Message-ID: <20181116231047.GA94365@spindle.one-eyed-alien.net> In-Reply-To: <7ehc-y6sm-wny@FreeBSD.org> References: <201809272108.w8RL8Xqn052122@repo.freebsd.org> <7ehc-y6sm-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 16, 2018 at 11:52:09PM +0100, Jan Beich wrote: > Brooks Davis <brooks@FreeBSD.org> writes: >=20 > > Author: brooks > > Date: Thu Sep 27 21:08:32 2018 > > New Revision: 338990 > > URL: https://svnweb.freebsd.org/changeset/base/338990 > > > > Log: > > Centralize compat support for PCIOCGETCONF. > > =20 > > The pre-7.x compat for both native and 32-bit code was already in > > pci_user.c. Use this infrastructure to add implement 32-bit support. > > This is more correct as ioctl(2) commands only have meaning in the > > context of a file descriptor. > > =20 > > Reviewed by: kib > > Approved by: re (gjb) > > Obtained from: CheriBSD > > Sponsored by: DARPA, AFRL > > Differential revision: https://reviews.freebsd.org/D17324 >=20 > After this commit getdevice() from pciconf(8) and pci_find_conf() in > tools/tools/dmardump/dmardump.c always fail in EPERM in -m32 mode. > Found via graphics/libdrm where PCIOCGETCONF is used to get a list of > DRM devices for use by OpenGL/Vulkan/VAAPI userland drivers. >=20 > Can you fix the regression before 12.0R or back the commit out? >=20 > https://lists.freebsd.org/pipermail/freebsd-current/2018-November/072144.= html Eeek, looks like I missed a case statment in a switch that I somehow didn't hit in testing. I'm building a potential fix now. -- Brooks --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJb7052AAoJEKzQXbSebgfA0MgH/3C9SUppFZABfuIFrj09Ez6K D+C5RqEpnaD3HordXoGCkS/drfyacO1S0KOBkDqikXmQfOalOlBUti1kDmf03puy G8GMfZL+LEOYxcX/rTlD47lmECt+iB6NTkXXixFKduixjj6bVBTU8ABcrq2iYHzf 115uieGyRAZtAcRA8gq4+6/cWephH+H40hPK9um6i3cR8CLRehPe318DMlHecrXL ZVdxkSwXc3S7nB/0Jy/s0w5C2OR33i8LFmb/nRn6MRRptcWLkfhd4SDTUUpknvpr ip/sSY3CK5vL99UDhMg9ap2510h6Ls8nxPf6x3Co6MKZ9iM7VuIYiALoDv3+Ebg= =yY6t -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181116231047.GA94365>