Date: Wed, 16 Nov 2016 16:31:51 -0800 From: Ngie Cooper <yaneurabeya@gmail.com> To: Mark Johnston <markj@freebsd.org> Cc: Sepherosa Ziehau <sephe@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r308664 - in head: contrib/hyperv/tools etc/devd etc/mtree include share/man/man4 sys/conf sys/dev/hyperv/utilities sys/modules/hyperv/utilities usr.sbin/hyperv usr.sbin/hyperv/tools us... Message-ID: <CAGHfRMB8U2X0aAqi-zd4tZV2zd4OhH%2B_7sU1dcQTXsmkBapNKA@mail.gmail.com> In-Reply-To: <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com> References: <201611150236.uAF2aCV8015106@repo.freebsd.org> <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston <markj@freebsd.org> wrote:
...
> This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of
> /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is
> needed in usr.sbin/hyperv/tools in order to preserve BINDIR from
> usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff
> below, but am not sure if this is the right way to do it. For some
> reason, doing this resulted in unused var warnings compiling
> hv_vss_daemon.c.
The -Wunused warnings you're seeing are because you're now it's
setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set
(I verified that), but then got unset between a few weeks ago and now
on the directory:
$ make -V.CURDIR -VWARNS
/usr/src/usr.sbin/hyperv/tools
$
Cheers,
-Ngie
PS -Wno-uninitialized is only set for gcc...? Really...???
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMB8U2X0aAqi-zd4tZV2zd4OhH%2B_7sU1dcQTXsmkBapNKA>