Date: Wed, 16 Jun 2004 15:53:37 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/bios apm.c apm.h Message-ID: <20040616155205.O36231@root.org> In-Reply-To: <20040616202815.1F8D716A4DE@hub.freebsd.org> References: <20040616202815.1F8D716A4DE@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 16 Jun 2004, Warner Losh wrote: > imp 2004-06-16 20:27:50 UTC > > FreeBSD src repository > > Modified files: > sys/i386/bios apm.c apm.h > Log: > o Return ai_batteries as 0xffffffff instead of -1. This is a nop change, but > placates gcc which seems to like to complain about -1 being assigned to > an unsigned value. It is well defined and intended, but since signess bugs > are being hunted just change to 0xffffffff. > o Mask the lower 8 bits, not the lower 4 bits for the ai_capabilities word. > All 8 bits are defined and the 0xf was almost certainly a typo. > o Define APM_UNKNOWN to 0xff for emulation layer. > > Revision Changes Path > 1.142 +2 -2 src/sys/i386/bios/apm.c > 1.4 +1 -0 src/sys/i386/bios/apm.h Thanks! Perhaps you can look at sys/i386/acpica/acpi_machdep.c and use your new #define as well as fix any -1 issues? -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040616155205.O36231>