Date: Tue, 8 Aug 2000 11:02:53 -0600 (MDT) From: Nate Williams <nate@yogotech.com> To: Alfred Perlstein <bright@wintelcom.net> Cc: David Greenman <dg@root.com>, current@FreeBSD.ORG Subject: Re: Ugly, slow shutdown Message-ID: <200008081702.LAA28034@nomad.yogotech.com> In-Reply-To: <20000808005100.A4854@fw.wintelcom.net> References: <200008080238.TAA40871@vashon.polstra.com> <200008080558.WAA05458@implode.root.com> <20000808005100.A4854@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> It's not just that, if you always have to cover your behind when
> doing tsleep you may wind up masking wakeup bugs. Places like
> "vfs_bio.c" line 586 of 3182:
>
> bp->b_xflags |= BX_BKGRDWAIT;
> tsleep(&bp->b_xflags, PRIBIO, "biord", 0);
> if (bp->b_xflags & BX_BKGRDINPROG)
> panic("bwrite: still writing");
> }
>
> If replaced by a while() _may_ obscure a buffercache bug.
>
> Personally I'd like to be able to catch such bugs than let them go
> because the API (wakeups can happen at any time) prohibits this.
No in a fully threaded world.....
Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008081702.LAA28034>