Date: Thu, 23 Jan 2014 11:12:09 +0100 From: Hans Petter Selasky <hps@bitfrost.no> To: Kevin Lo <kevlo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r261014 - head/sys/dev/usb/wlan Message-ID: <52E0EAF9.5080406@bitfrost.no> In-Reply-To: <52E0E36E.2070509@FreeBSD.org> References: <201401220957.s0M9vQfY070899@svn.freebsd.org> <52E0E36E.2070509@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/23/14 10:39, Kevin Lo wrote: > > On 2014/01/22 17:57, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Wed Jan 22 09:57:26 2014 >> New Revision: 261014 >> URL: http://svnweb.freebsd.org/changeset/base/261014 >> >> Log: >> - Fix some non-portable code with regard to endianness. Don't use >> memmove(). >> - Fix a range check for maximum transmit length. >> - Fix read from missing field when transmitting data. >> MFC after: 2 weeks > > I appreciate you're taking the time to fix code, but your change totally > breaks RT3573 and IQ calibration doesn't work for RT5372 and RT5572. > I think it'd be good to send me the patch for testing/review > before committing. Thanks! > > Kevin > > Hi Kevin, That's fine. I don't have that chipset to test with. My dongle was working fine with the given patches. The fixes were based on code inspection. Will you send a new patch to fix the issues I've mentioned today? There are clearly some bugs in there either with or without the patch. Thank you! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52E0EAF9.5080406>