Date: Mon, 19 Jan 2009 00:58:25 -0700 From: Scott Long <scottl@samsco.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r187426 - head/sys/amd64/conf Message-ID: <497432A1.9060805@samsco.org> In-Reply-To: <200901190710.n0J7ACSg001385@svn.freebsd.org> References: <200901190710.n0J7ACSg001385@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > Author: sobomax > Date: Mon Jan 19 07:10:11 2009 > New Revision: 187426 > URL: http://svn.freebsd.org/changeset/base/187426 > > Log: > Add asr(4) and stge(4) from i386 GENERIC. Both drivers compile on amd64 and > there is no particular reason for them to be i386-only. Yes, there is a particular reason why asr is i386 only. This has been discussed extensively over the years, but to sum it up, no it is not 64-bit clean. Please remove. At this point in the lifecycle of amd64, you can be 100% assured that the list of compatible devices has been checked and rechecked a few dozen times. You are not going to find hidden gems that people have forgotten about. If you think you've found something, ask first, and prepare to be wrong. And above all else, don't put drivers into here that you haven't tested. It's pretty silly to admit in your commit message, for all to see, that you are blatantly committing without testing. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?497432A1.9060805>