Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Mar 1997 19:12:11 +0100
From:      j@uriah.heep.sax.de (J Wunsch)
To:        current@freebsd.org
Subject:   Re: ppp
Message-ID:  <19970311191211.UO03451@uriah.heep.sax.de>
In-Reply-To: <Pine.BSF.3.95q.970311183635.1003B-100000@nagual.ru>; from ??????????????? on Mar 11, 1997 18:41:59 %2B0300
References:  <199703111513.CAA17912@godzilla.zeta.org.au> <Pine.BSF.3.95q.970311183635.1003B-100000@nagual.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
As Andrey wrote:

>  PPP code was written in assumptions that SIGALRM reaction
> is not delayed, so if we trust developer, he choose timeout + handler
> action in the way that signals not missed.

The PPP developer however did *way* too many things inside his signal
handlers.  Remember, signal handlers are not running in normal process
context.  It's always a good idea to restrict your doing inside the
handler to the absolutely necessary minimum.  Sending packets and
shuffling large amounts of data does certainly not belong to this
category.

This PPP state machine would probably benefit from a multithreaded
implementation.  I'm afraid the FreeBSD camp lacks enough clueful
developers for such an implementation, however.

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970311191211.UO03451>