Date: Fri, 1 Feb 2008 13:48:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Beech Rintoul <beech@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/multimedia/xmms Makefile Message-ID: <20080201134834.GA54677@FreeBSD.org> In-Reply-To: <200801311929.m0VJTU0t086567@repoman.freebsd.org> References: <200801311929.m0VJTU0t086567@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 31, 2008 at 07:29:30PM +0000, Beech Rintoul wrote:
> beech 2008-01-31 19:29:30 UTC
>
> FreeBSD ports repository
>
> Modified files:
> multimedia/xmms Makefile
> Log:
> - Add options
> - Pet portlint
> - Bump portrevision
> - Take maintainership
Couple of questions:
- Option descriptions could've been expanded (missing "Build
with"/"Enable" as vast majority of other ports do)
- It seems that "ipv6" could be better spelled as "IPv6", and "Plugin"
as mere "plugin"; ditto for "Fileinfo"
- Mixing OPTIONS and @${ECHO_MSG} "You can enable ... by defining
WITH_FOO" looks strange, any particular reason for that?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080201134834.GA54677>