Date: Mon, 6 Dec 1999 14:14:57 +0100 From: Martin Cracauer <cracauer@cons.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh expand.c parser.c Message-ID: <19991206141456.A8553@cons.org> In-Reply-To: <199912041712.JAA38380@freefall.freebsd.org>; from Martin Cracauer on Sat, Dec 04, 1999 at 09:12:49AM -0800 References: <199912041712.JAA38380@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In <199912041712.JAA38380@freefall.freebsd.org>, Martin Cracauer wrote: > cracauer 1999/12/04 09:12:49 PST > > Modified files: > bin/sh expand.c parser.c > Log: > Fix "subscript has type `char'" warnings by casting to int, as > discussed on -arch. Before any more people point it out: sh is not even remotely 8-bit clean and double-casting (int)(usigned char)c to expand a negative sign to += 128 makes things worse, not better. Not sure wether I should give it a try before the feature freeze. Anyone has scripts with umlauts he wants to submit for testing? Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer@cons.org> http://www.cons.org/cracauer/ Tel.: (private) +4940 5221829 Fax.: (private) +4940 5228536 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19991206141456.A8553>